Does Code Cleanliness Affect Coding Agents?

(arxiv.org)

68 points | by softwaredoug 5 hours ago

11 comments

  • minimaxir 1 hour ago
    One trick I've found that works well is to tell it to refactor, e.g for Python:

        Refactor the Python code to make it more Pythonic, e.g. fewer classes/singletons, especially if it will provide a speedup. The Python code **MUST** follow code organization standards expected of popular open-source Python packages code without causing any benchmark performance regressions.
    
    A variant I've used for Rust code:

        The Rust codebase in `/src` has become bloated with several files >1k LoC. Refactor the Rust codebase to fit code organization standards expected of popular open-source Rust code without causing any benchmark performance regressions.
    
    Those types of prompts appear to a) reorganize the code logically and b) do seem to get better performance from the agents because the file names now provide semantic hints to where relevant code resides. For bloated 5k LoC files, the agent has to Read several chunks to find relevant code which is inefficient.

    In terms of benchmark performance it generally improves after the refactor which I suspect is coincidental (especially in Rust where it shouldn't matter due to compiling) but I'm not complaining.

    • woggy 8 minutes ago
      Asking it to apply the YAGNI principle also sems to work well for trimming codebases down. Generally ask it to review, generate a list of review points, then we go through each one together and I make a decision yes/no on each one (or suggest further modifications).
    • loremium 26 minutes ago
      the word your looking for is idiomatic
      • bckr 14 minutes ago
        Yes and Pythonic is the Pythonic word for idiomatic
    • cpill 1 hour ago
      yeah, me too. I usually ask it to do a code review using SOLID standards and it usually does a good job, if not a little overkill sometimes.
  • i_have_an_idea 3 hours ago
    In my experience, the delta in agent performance is substantial if the codebase is littered with dead code, redundant code, unreachable fallbacks, leaking abstractions and half-baked design patterns vs if the code is well-organized, with clear data flow, with good encapsulation and clean architecture. Like, I've seen all the frontier models have to do several rounds of code review / QA and fix when the code is bad vs just getting it right at the 1st/2nd attempt.
    • yoyohello13 1 hour ago
      I’ve been working with these things for quite some time now and every time I simply “treat it like I would a human” it seems to perform better. I can’t imagine agents wouldn’t perform better in a clean codebase than a giant mess of one. Just like it performs better when it has well formed specs and access to documentation.
      • jaggederest 59 minutes ago
        It actually goes even further than humans, humans can pretty rapidly get inured to things being awkward or messy and stop noticing, but the context for agents is taking up the same space and "attention" every time they're run, and they're creations entirely of context, so the quality and examples matter massively.
    • hannofcart 2 hours ago
      Some of the issues mentioned above like dead code removal, code duplication, unreachable code are already solved using deterministic linters for quite a while now for most language ecosystems.

      You can get the LLM to run a script which checks for all of these and also enforce them by running the same script as a pre-commit hook. Setting this up religiously in every code base I work on has been what's given me the most mileage with agentic coding.

      I wrote down a more detailed post of the various linters I use here:

      https://www.balajeerc.info/Use-Deterministic-Guardrails-for-...

      • rafaelmn 1 hour ago
        > Some of the issues mentioned above like dead code removal, code duplication, unreachable code are already solved using deterministic linters for quite a while now for most language ecosystems.

        I have legacy endpoints that are no longer used in practice, there for historical reasons, intertwined with existing code etc. They might be marked obsolete, services implementing it are not - agent greps those, builds off of them - produces half legacy garbage.

        Linters only handle trivial cases most of us already solved.

    • BobbyTables2 2 hours ago
      Feel the same way myself when working in messy codebases… At some point, the horrible patterns start to rub off…
    • ramraj07 2 hours ago
      I was reading your comment, agreeing with it but still feeling why this is a bad comment. It just occurred to me that an anecdotal statement like this is the antithesis of scientific discourse. We have a paper here, trying to answer a question, and anecdotal testimonials can only harm the discussion by biasing readers without adding anything of value to let anyone objectively conclude anything on the problem.

      The most useful discussion would be if we all read the paper and critique its methodology or results.

    • dnautics 2 hours ago
      i mean this is feeling too but im too paranoid and frequently do refactoring and code organization passes and never don't do it, so i cant say i know for sure there is a delta.

      though people who complain that llms aren't that great strike me as the type to have messy code bases

  • ngsevers 2 hours ago
    Even if agents can learn to navigate all the stubs and WET crap they leave behind do we really want a code base that no human can follow what's actually going on?
    • softwaredoug 2 hours ago
      Even if the agent does everything, English is an imprecise description of what the code does.

      So I personally at a minimum will want to talk “in code” about what code does.

      • ngsevers 2 hours ago
        Sure, but that only happens with a clean, concise, human readable codebase. If agents start working directly in binary, it'd be a lot harder to interact and understand what's going on and where the points of failure are..
  • Gigachad 2 hours ago
    I can't imagine how it wouldn't. None of them can fit a real codebase in context and have to browse the code the same way a person would. Doing searches and reading files. If the files are in the places they would be expected to be and things are called what the model or a person would first guess to search then it gets found in the first attempt rather than requiring a deep search and multiple attempts.
    • Supermancho 1 hour ago
      An LLM doesnt have to hold the whole codebase in context. Every path, then shift to next paths because you can ignore sections covered. Much like a developer would.
  • ford 40 minutes ago
    In my experience everything that affects engineers affects an agent. Good abstractions, reasonably sized methods, good names, principled (intra & inter) service architecture, unit tests, etc.

    All of these things have historically been the job of engineers, because it helps other people contribute to the code.

    Now it helps other people and other agents contribute to the code.

  • wgd 2 hours ago
    "agent pipelines that [...] clean a messy [repository]"

    This feels like a terrible approach, sufficient to condemn the entire study.

    Apparently half of the "minimal pairs" in this work were constructed in this way. I simply am not going to trust any conclusion that requires assuming these AI "cleaned" repos are in any way representative of actually-good codebases.

    • ramraj07 2 hours ago
      Would you trust clean repos that are messed up by AI?
      • wgd 1 hour ago
        Yes, those ones would be at least a somewhat-plausible simulation of a real scenario people care about: a once-clean codebase that was allowed to become messy by a succession of insufficiently-careful vibeslop PRs.

        I'm not a huge fan of their methodology for the AI-degraded cases either (ideally one would set up the mirror pairs by taking some real repositories and rewinding history a month or so and then having a succession of independent agents reimplement each bit of feature work and bugfixes over that period of time), but it's at least a coarse approximation whereas I just don't trust the cleanup methodology to resemble anything real in the first place.

      • smallerize 2 hours ago
        No, because the outputs will still be "in distribution" so to speak.
  • rgoulter 2 hours ago
    Another consideration: written by hand, the trade-off of development velocity vs well organised code means that it can be worth taking some tech debt now in order to deliver some value now. (Especially when prototyping etc.).

    With coding agents, agents can produce code quicker. The same trade-off still applies.. but, the time it takes an LLM coding agent to write well organised code is still going to be quicker than the time it takes me to write scrappy code.

    • softwaredoug 2 hours ago
      Yes this is one reason IMO I think of AI code as instant legacy code.

      You take on a lot of tech debt. Then you need to do the same work you would do with any legacy app: finding where the brittle points are, what needs better testing, which leads to breaking apart the big ball of mud into cleaner components.

  • jaxn 2 hours ago
    agents are pretty good at cleaning up a codebase, finding dead code, fixing bad abstractions, etc. You just have to spend some focusing the agents on that goal.
  • adamtaylor_13 1 hour ago
    [dead]
  • ahonn 1 hour ago
    [flagged]
  • jakubmazanec 3 hours ago
    "Across 660 trials with Claude Code, code cleanliness does not change the agent's pass rate. However, it substantially alters the agent's operational footprint: agents working on cleaner code use 7 to 8% fewer tokens and reduce file revisitations by 34%. Our findings suggest that traditional maintainability principles remain highly relevant in the era of AI-driven development [...]"